Skip to content

Add param variable for group id #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,11 @@ public ApplicationEventListener(ReactiveMessageListener receiver,
DiscardNotifier discardNotifier,
CustomReporter errorReporter,
String appName) {


super(receiver, withDLQRetry, createTopology, maxRetries, retryDelay, discardNotifier,
"event", errorReporter, appName + "-events", resolver.getEventNames());
"event", errorReporter, appName, resolver.getEventNames());

this.resolver = resolver;
this.messageConverter = messageConverter;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
@SuperBuilder
public abstract class GenericAsyncProps<P> {
private String appName;
private String groupId;
private String secret;

public abstract void setConnectionProperties(P properties);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ public class GenericAsyncPropsDomain<T extends GenericAsyncProps<P>, P> extends
private Class<P> propsClass;

public GenericAsyncPropsDomain(String defaultAppName,
String groupId,
P defaultProperties,
GenericAsyncPropsDomainProperties<T, P> configured,
SecretFiller<P> secretFiller,
Expand All @@ -44,7 +45,10 @@ public GenericAsyncPropsDomain(String defaultAppName,
+ " has not set the property appName. please use respective property or " +
" spring.application.name property or withDefaultAppName in builder");
}
value.setAppName(defaultAppName);
if(value.getGroupId() != null){
value.setAppName(groupId);
}
value.setAppName(defaultAppName + "-events");
}
if (value.getConnectionProperties() == null) {
if (defaultProperties == null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,11 @@
public class AsyncKafkaPropsDomain extends GenericAsyncPropsDomain<AsyncKafkaProps, KafkaProperties> {

public AsyncKafkaPropsDomain(@Value("${spring.application.name}") String defaultAppName,
@Value("${spring.kafka.consumer.group.id}") String groupId,
KafkaProperties defaultKafkaProperties,
AsyncKafkaPropsDomainProperties configured,
KafkaSecretFiller kafkaSecretFiller) {
super(defaultAppName, defaultKafkaProperties, configured, kafkaSecretFiller, AsyncKafkaProps.class,
super(defaultAppName, groupId, defaultKafkaProperties, configured, kafkaSecretFiller, AsyncKafkaProps.class,
KafkaProperties.class);
}

Expand Down
Loading