remove unneccessaries from pch to reduce size and fix storage quota issues in build #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lgtm assuming this still builds after removal. |
NickGerleman
approved these changes
May 12, 2021
|
this will reduce the pch size (known to be large) at the expense of slower builds (recompiling the same headers everywhere they are used), which for xaml headers can be significant. |
|
agreed. but if it doesn’t build at all because it generates a gig of pch and exceeds the build agent storage quota, then that perf gain is a detriment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
significant reduction in size of PCH by removing unnecessary includes