Skip to content

Conversation

lukailun
Copy link

Thanks for the package.

GuardedResultAsyncTask is being used in RNDocumentPickerModule.java which is no longer supported in react-native 0.78.0. This is the fix for react-native-document-picker package.

And is it possible to make a new release for react-native-document-picker after the fix, currently I cannot migrate to @react-native-documents/picker.

Copy link

changeset-bot bot commented May 13, 2025

🦋 Changeset detected

Latest commit: e41b9ae

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@vonovak vonovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello and thank you for the PR!
The way I see it, there are a bit too many changes here.
AFAICT, it should be enough to change GuardedResultAsyncTask to AsyncTask.

I know that class is deprecated but for the sake of unblocking 78, I'd prefer to do minimal changes.

For those who don't want to use deprecated stuff, please move over to @react-native-documents/picker.

Thank you! :)

@lukailun
Copy link
Author

I understand your point about making minimal changes, especially for a deprecated package.

@maxpowa
Copy link

maxpowa commented Oct 10, 2025

For anyone who stumbles upon this in the future, I created a patch-package patch to apply the suggested minimal fix from @vonovak. Slightly lower friction than migrating to the new package in some cases.

https://gist.github.com/maxpowa/0b37709c54130909f8d32b39542494c8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants