-
Notifications
You must be signed in to change notification settings - Fork 579
[apiserver] Add migration doc from v1 to v2 #3812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Dongjun Na <[email protected]>
Co-authored-by: Jun-Hao Wan <[email protected]> Signed-off-by: Dongjun Na <[email protected]>
CC @rueian / @kevin85421 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the doc! I think it's clear and concise.
Meanwhile, as I commented in the google doc, do we plan to add some examples on code migration?
|
||
With v2, we eliminate these bottlenecks by directly reusing the OpenAPI schema defined in the Kubernetes CRDs. | ||
Instead of manually defining fields or generating new clients, v2 acts as a transparent HTTP proxy to the | ||
Kubernetes API server. All CRD fields are exposed by default, and advanced behaviors such as compute template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for my own curiosity (not request to change), why do we manually break lines, instead of writing a long line, which automatically breaks into multiple lines when display?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see — I didn’t know that. Thanks for the explanation.
|
||
## Dev Progress | ||
|
||
- Not all v2 features will ship in the kuberay v1.4 release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC @rueian do we want a timeline for v2 release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the timeline can be:
- We try to support compute templates in KubeRay 1.5.0, but still keep the API server v2 in Alpha.
- Announce Beta since KubeRay 1.6.0
Co-authored-by: Nary Yeh <[email protected]> Signed-off-by: Dongjun Na <[email protected]>
Co-authored-by: Nary Yeh <[email protected]> Signed-off-by: Dongjun Na <[email protected]>
Co-authored-by: Nary Yeh <[email protected]> Signed-off-by: Dongjun Na <[email protected]>
Co-authored-by: Nary Yeh <[email protected]> Signed-off-by: Dongjun Na <[email protected]>
Co-authored-by: Nary Yeh <[email protected]> Signed-off-by: Dongjun Na <[email protected]>
Co-authored-by: Nary Yeh <[email protected]> Signed-off-by: Dongjun Na <[email protected]>
@machichima Nice catch, thanks! |
|
||
## Dev Progress | ||
|
||
- Not all v2 features will ship in the kuberay v1.4 release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the timeline can be:
- We try to support compute templates in KubeRay 1.5.0, but still keep the API server v2 in Alpha.
- Announce Beta since KubeRay 1.6.0
Co-authored-by: Rueian <[email protected]> Signed-off-by: Dongjun Na <[email protected]>
Why are these changes needed?
Related issue number
Closes #3607
Checks