Added some Waveshare board support #2628
Open
+694
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurch
reviewed
Aug 14, 2025
| // SHOULD ONLY CONSIST OF PREPROCESSOR DIRECTIVES | ||
| // ----------------------------------------------------- | ||
|
|
||
| // This header may be included by other board headers as "boards/waveshare_rp2350_relay_6ch.h" |
There was a problem hiding this comment.
Comment here doesn't match the filename. Same error also in waveshare_rp2350_touch_amoled_2.41.h.
lurch
reviewed
Aug 14, 2025
| pico_board_cmake_set(PICO_PLATFORM, rp2350) | ||
|
|
||
| // For board detection | ||
| #define RASPBERRYPI_PICO2 |
There was a problem hiding this comment.
This should also be set to something unique for each file, see e.g. https://github.com/raspberrypi/pico-sdk/blob/develop/src/boards/include/boards/waveshare_rp2040_lcd_0.96.h#L18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some weveshare board support,PTAL.