fix: raise DeviceNotFound exception if device is not online in filter #471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes the behavior of the
get_intf_ip
filter when applied to devices that are not online.Previously, the filter would always invoke
device.ready()
, which internally polls the device up to 18 times before giving up. This led to unnecessary delays and wasted time in cases where the device was already offline.With this change, the filter first checks whether the device is online. If the device is not online, it will skip the ready-state polling and fail fast, avoiding the long wait.
Why this change is needed
Impact
get_intf_ip
filter logic.