Deprecate RMM_DEFAULT_HOST_ALIGNMENT #2153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds deprecation warning to RMM_DEFAULT_HOST_ALIGNMENT constant.
harrism
approved these changes
Nov 19, 2025
rongou
approved these changes
Nov 19, 2025
bdice
added
breaking
karthikeyann
approved these changes
Nov 19, 2025
Contributor
Author
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Nov 19, 2025
…0661) This fixes the breaking in JNI code which uses the deprecated and deleted `rmm` interface. Also removes usage of `RMM_DEFAULT_HOST_ALIGNMENT`, following up from rapidsai/rmm#2153. Authors: - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) Approvers: - Bradley Dice (https://github.com/bdice) - Peixin (https://github.com/pxLi) - Shruti Shivakumar (https://github.com/shrshi) - Karthikeyan (https://github.com/karthikeyann) - Vukasin Milovanovic (https://github.com/vuule) - Lawrence Mitchell (https://github.com/wence-) URL: #20661
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds deprecation warning to
RMM_DEFAULT_HOST_ALIGNMENTconstant.Missed in #2104. Part of #2103.