Remove references to Visual Studio < 2019 #773
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroSteiner
commented
Sep 18, 2025
There was a problem hiding this comment.
There's a lot of code duplication in this file from make.bat. I'm not entirely sure what it was for because the build automation uses make.bat which I updated. The git history shows this file was copied from make.bat originally but it hasn't been maintained with for example, the debug builds.
If there's a reason to keep it I'm happy to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the build automation internally at Rapid7 is using v141_xp to match what the developers are using and to prepare for a possible update to v143 / VS2022 this cleans up references to previous versions of Visual Studio. This effectively takes the stance that our new minimum supported version of VS is 2019 with the
v141_xptoolchain, no morev120. The intention is to clarify that the project isn't intended to build with v120 anymore.