Skip to content

Conversation

mwalas-r7
Copy link
Contributor

@mwalas-r7 mwalas-r7 commented Aug 22, 2025

This PR fixes missing weak ciphers from the ssl_version scanner output. OpenSSL was replaced by Rex library.

Verification

  • Start msfconsole
  • use auxiliary/scanner/ssl/ssl_version
  • set rhosts localhost - target server with weak certificates and ciphers enabled, default port is 443
  • run
  • Verify Certificate Information
  • Verify that certificate is saved to loot
  • Verify that information about public key size is visible
  • Verify that each enabled protocol version has a list of all accepted ciphers
  • Verify that detailed scan results are saved to loot

# Store certificate in loot with rex-sslscan metadata
loot_cert = store_loot(
'ssl.certificate.rex_sslscan',
'text/plain',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can be more specific here. When certs are stored on disk they're usually in a specific format like PEM or PKCS12. We should set the MIME type here to reflect that more accurately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smcintyre-r7 i have adjusted the mime type and format of the saved certiticate

@mwalas-r7 mwalas-r7 force-pushed the fix/ssl-version-scanner branch from 86a93e4 to 6c77f74 Compare August 25, 2025 19:42
@mwalas-r7 mwalas-r7 requested a review from smcintyre-r7 August 25, 2025 19:46
Copy link
Contributor

@smcintyre-r7 smcintyre-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good to me. In this side by side test, the old version is on the left while the new version is on the right. You can see that extra ciphers are being identified in the version on the right.

image

The certificate is also stored as a PEM file so we have a copy on disk and can obtain additional information later. The mime type for the PEM file looks correct. I ran this test using a hostname zerosteiner.com and also noticed that the old version was failing when connected to the database while the new one is not.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Metasploit Kanban Aug 26, 2025
@smcintyre-r7 smcintyre-r7 merged commit c56bfca into rapid7:master Aug 26, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Metasploit Kanban Aug 26, 2025
@smcintyre-r7
Copy link
Contributor

Release Notes

This updates the auxiliary/scanner/ssl/ssl_version module to use the rex-sslscan gem to check for additional ciphers that can be negotiated with the target. This results in a more comprehensive test.

@adfoster-r7 adfoster-r7 added the rn-enhancement release notes enhancement label Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug rn-enhancement release notes enhancement
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants