feat: add xrpl types #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeager-eren
force-pushed
the
feat/add-xrpl
branch
from
7d20a17 to
f3703bd
Compare
9 tasks
RyukTheCoder
requested changes
Jun 15, 2025
yeager-eren
force-pushed
the
feat/add-xrpl
branch
from
6aa6ca7 to
fe03267
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding XRPL types to the supported blockchains.
Currently, Our server only returning Payment, but I've added TrustSet as well since client needs to create that transaction itself (it's similar to EVM approval).
The server will return XRPL.js types as
datain its response, So I copy pasted the type from that lib. The reason I didn't add the lib as dependency is it will increase the package size and we only need some typings, I also couldn't add to devDependencies since the types are publishing and exists in output, so it will not be installed on developer's machine.part of rango-exchange/rango-client#1096