Skip to content

Conversation

@arlert-armin
Copy link
Contributor

@arlert-armin arlert-armin commented Nov 30, 2025

Summary

This PR integrates Binance Wallet into the Hub and aligns its behavior with the Hub’s EVM namespace and capability model.
Binance Wallet provides broad EVM chain support and behaves correctly across connection, account switching, signing, and network handling. The only notable limitation is the lack of an auto-connect mechanism.

Implementation notes / limitations

Group

EVM

Binance Wallet supports the following EVM chains:

  • ETHEREUM
  • OPTIMISM
  • LINEA
  • METIS
  • BLAST
  • CELO
  • FANTOM
  • MONAD
  • SONIC
  • BERACHAIN
  • BASE
  • ZETA_CHAIN
  • ARBITRUM
  • BSC
  • SCROLL
  • AVAX_CCHAIN

All chains above have been integrated into the Hub’s EVM resolver and connection pipeline.

Feature

❌ Auto Connect

Binance Wallet does not support eager-connect (silent connection).

All other features—connection, account switching, signing, and network handling—work properly with no additional known limitations.

Related PRs

Fixes # (issue)

How did you test this change?

Binance Wallet was tested end-to-end within the Hub environment:

  • Verified manual connection flow on all supported EVM networks.

  • Confirmed correct account retrieval and address exposure.

  • Tested network switching inside Binance Wallet and ensured the Hub updates correctly.

  • Executed signing operations to validate compatibility.

  • Test A

  • Test B

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

@arlert-armin arlert-armin force-pushed the feat/rf-2812-integrate-binance-web3-wallet branch 2 times, most recently from 9ca150c to 39d8edb Compare December 3, 2025 14:04
@arlert-armin arlert-armin force-pushed the feat/rf-2812-integrate-binance-web3-wallet branch from 39d8edb to fd21e8d Compare December 4, 2025 03:11
@arlert-armin arlert-armin force-pushed the chore/accept-getAccounts-on-evm-connect branch from cc41e86 to 9909e8b Compare December 4, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants