Skip to content

Conversation

@arlert-armin
Copy link
Contributor

Summary

This PR migrates Braavos to the Hub and ensures full compatibility with the updated connection and namespace architecture.
The integration required aligning Braavos’ flows with the Hub’s standardized capability and connection model. The migration was straightforward, and no limitations were identified during implementation.

Key changes:

  • Migrated Braavos to use the Hub-managed connection flow.
  • Ensured Starknet-related logic aligns with previously added Starknet namespace support in the core.
  • Validated that all Braavos operations (connection, account fetching, signing) work correctly under the Hub orchestration.

No known limitations were found.

Fixes # (issue)

How did you test this change?

I manually tested Braavos under the Hub environment to ensure all core functionalities behave as expected:

  • Verified connection flow through the Hub.

  • Confirmed correct Starknet account retrieval and address handling.

  • Tested signing operations to ensure compatibility.

  • Test A

  • Test B

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

@arlert-armin arlert-armin force-pushed the feat/migrate-ready-to-the-hub branch from cc94b3f to 888a98e Compare November 30, 2025 07:58
@arlert-armin arlert-armin force-pushed the feat/migrate-braavos-to-the-hub branch from 53d772a to f7acf5a Compare November 30, 2025 08:05
@arlert-armin arlert-armin changed the base branch from feat/migrate-ready-to-the-hub to feat/add-starknet-namespace-to-the-hub November 30, 2025 08:42
@arlert-armin arlert-armin force-pushed the feat/add-starknet-namespace-to-the-hub branch 2 times, most recently from 5053014 to 602e2d2 Compare December 3, 2025 13:56
@arlert-armin arlert-armin force-pushed the feat/migrate-braavos-to-the-hub branch 3 times, most recently from cea0f51 to 605f279 Compare December 3, 2025 14:18
@arlert-armin arlert-armin force-pushed the feat/add-starknet-namespace-to-the-hub branch from 602e2d2 to 905f04b Compare December 4, 2025 03:18
@arlert-armin arlert-armin force-pushed the feat/migrate-braavos-to-the-hub branch from 605f279 to 9e63d0c Compare December 4, 2025 03:23
@arlert-armin arlert-armin force-pushed the feat/add-starknet-namespace-to-the-hub branch 2 times, most recently from 34ff74c to a60ba78 Compare December 6, 2025 09:39
Base automatically changed from feat/add-starknet-namespace-to-the-hub to next December 6, 2025 10:06
@arlert-armin arlert-armin merged commit 2b34b8e into next Dec 6, 2025
9 checks passed
@arlert-armin arlert-armin deleted the feat/migrate-braavos-to-the-hub branch December 6, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants