-
Notifications
You must be signed in to change notification settings - Fork 36
feat: migrate ready to the hub #1302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+290
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c878938 to
7bf7631
Compare
2c50d03 to
a75e0e7
Compare
Base automatically changed from
feat/rf-2763-make-subscriber-builder-accept-fallback
to
next
November 22, 2025 09:29
9431967 to
6507542
Compare
7bf7631 to
b6b03b8
Compare
cc94b3f to
888a98e
Compare
yeager-eren
approved these changes
Dec 1, 2025
602e2d2 to
905f04b
Compare
888a98e to
991f9be
Compare
905f04b to
34ff74c
Compare
90e3268 to
b0b7d61
Compare
34ff74c to
a60ba78
Compare
Base automatically changed from
feat/add-starknet-namespace-to-the-hub
to
next
December 6, 2025 10:06
7c8af51 to
1561d97
Compare
1561d97 to
ec3626f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates Ready to the Hub and introduces Starknet namespace support in the core.
The migration required updating Ready’s connection flow to align with the Hub architecture, but no blockers or limitations were encountered. Starknet namespace integration was added cleanly, with no breaking changes to existing flows.
Key changes:
No known limitations were found.
Related PRs:
#1325
Fixes # (issue)
How did you test this change?
I validated the new implementation across both Ready and Starknet flows:
Confirmed Ready connects successfully via the Hub with expected behavior.
Verified Starknet namespace resolution, connection, and account retrieval.
Test A
Test B
Checklist: