-
Notifications
You must be signed in to change notification settings - Fork 37
feat: add solana support to metamask #1268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
arlert-armin
merged 4 commits into
next
from
feat/rf-2671-add-solana-support-to-metamask
Oct 6, 2025
Merged
feat: add solana support to metamask #1268
arlert-armin
merged 4 commits into
next
from
feat/rf-2671-add-solana-support-to-metamask
Oct 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyukTheCoder
requested changes
Sep 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tnx for your contribution, just added some comments.
06c0570
to
7421f1c
Compare
RyukTheCoder
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
57d5334
to
73df755
Compare
73df755
to
0dba8f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Solana support to the MetaMask Provider by implementing the Wallet Standard. The core challenge was a mismatch between the method signatures and behavior of our previous default injected provider instance and the new Wallet Standard-based instance.
To unblock this high-priority integration, the initial implementation includes:
SolanaSigner
class, as the signer methods (e.g.,signMessage
,signTransaction
) on the Wallet Standard instance are different from those on our legacy injected provider.This is a stopgap solution. The long-term plan is to deprecate this custom code once Wallet Standard support is fully integrated and standardized into the core, at which point we will use the core actions instead.
Fixes # (issue)
How did you test this change?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: