Skip to content

Conversation

arlert-armin
Copy link
Contributor

Summary

This PR adds Solana support to the MetaMask Provider by implementing the Wallet Standard. The core challenge was a mismatch between the method signatures and behavior of our previous default injected provider instance and the new Wallet Standard-based instance.

To unblock this high-priority integration, the initial implementation includes:

  1. A custom SolanaSigner class, as the signer methods (e.g., signMessage, signTransaction) on the Wallet Standard instance are different from those on our legacy injected provider.
  2. A temporary set of custom actions to handle Solana-specific operations through the new Wallet Standard interface.

This is a stopgap solution. The long-term plan is to deprecate this custom code once Wallet Standard support is fully integrated and standardized into the core, at which point we will use the core actions instead.

Fixes # (issue)

How did you test this change?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

Copy link
Contributor

@RyukTheCoder RyukTheCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx for your contribution, just added some comments.

Copy link
Contributor

@RyukTheCoder RyukTheCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arlert-armin arlert-armin force-pushed the feat/rf-2671-add-solana-support-to-metamask branch from 73df755 to 0dba8f8 Compare October 6, 2025 13:08
@arlert-armin arlert-armin merged commit 7d7f521 into next Oct 6, 2025
5 checks passed
@arlert-armin arlert-armin deleted the feat/rf-2671-add-solana-support-to-metamask branch October 6, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants