fix(ci): fail workflow when npm publish errors #1159

nikaaru · 2025-05-31T15:20:47Z

Summary

Ensure the GitHub Actions workflow fails if the npm publish step encounters an error. Previously, a failed publish did not mark the job as “failed,” confusing the package’s release status.

Fixes # (issue)

How did you test this change?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test A
Test B

Checklist:

I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

…nto-branch-next Chore/merge branch main into branch next

- [email protected] Affected packages: [email protected] [skip ci]

- [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected] [skip ci]

- [email protected] - [email protected] Affected packages: [email protected],[email protected] [skip ci]

- [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected] [skip ci]

[skip ci]

- [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected] [skip ci]

Chore/sync next and main

- [email protected] - [email protected] Affected packages: [email protected],[email protected] [skip ci]

Merge branch 'main' into chore/sync-with-main

…ls modal

- [email protected] Affected packages: [email protected] [skip ci]

RyukTheCoder and others added 30 commits January 21, 2025 09:52

Merge branch 'main' into 'next'

c97037c

Merge pull request #996 from rango-exchange/chore/merge-branch-main-i…

12b4452

…nto-branch-next Chore/merge branch main into branch next

fix: close wallet connection modal after connect with namespace

29dff44

chore(release): publish

3b58470

- [email protected] Affected packages: [email protected] [skip ci]

fix: usdValue shouldn't be formatted to calculate the total value

0e2d987

chore(release): publish

3f35384

- [email protected] Affected packages: [email protected] [skip ci]

fix: updated profile banner format from png to jpg

3100a66

chore(release): publish

6c772f2

- [email protected] Affected packages: [email protected] [skip ci]

fix: update connected namespaces in storage on switch account

782ec1d

chore(release): publish

327255a

- [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected] [skip ci]

fix: remove namespace from storage on auto connect failure

6b6504f

chore(release): publish

2bde9c5

- [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected] [skip ci]

feat: add money bag icon

23f3961

chore(release): publish

7dee06c

- [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected] [skip ci]

feat: update payload for events

36a11b6

chore(release): publish

e673a90

- [email protected] - [email protected] Affected packages: [email protected],[email protected] [skip ci]

feat: add disconnect all to hub adapter

c9934cc

chore(release): publish

451048d

- [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected] [skip ci]

chore: remove experimental wallets from widget config

285f88b

chore(release): deploy

9292775

[skip ci]

chore(release): publish

b66877d

- [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected] [skip ci]

chore: refactor get legacy providers

8c4571e

chore(release): publish

b8cbf02

- [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected] [skip ci]

Merge branch 'main' into chore/sync-next-and-main

fa8ed1d

Merge pull request #1010 from rango-exchange/chore/sync-next-and-main

9ca2d79

Chore/sync next and main

chore(release): publish

74c6ac2

- [email protected] - [email protected] Affected packages: [email protected],[email protected] [skip ci]

chore: upgrade eslint to v9

2bfa580

chore: remove a deprecated flag from eslint cli

4847864

yeager-eren and others added 19 commits May 26, 2025 17:00

Merge pull request #1151 from rango-exchange/chore/sync-with-main

d7dd15c

Merge branch 'main' into chore/sync-with-main

refactor: remove dependency to legacy provider on get wallet info

4018d53

fix: avoid hub recreation

2e5fc07

fix: fix incorrect state after connecting evm namespace on hub wallets

778bba9

chore: remove mytonwallet provider

c6372da

chore: remove solflare snap provider

51a3782

fix: correct the formatting of the total payable fee in the fee detai…

ee052d3

…ls modal

feat: integrate slush wallet

9e9a5cc

chore: add isSupported flag to getConnectedWalletsDetails result

e46c2e9

chore(release): publish

b6f8f43

- [email protected] Affected packages: [email protected] [skip ci]

feat: migrate trust wallet to use hub and add support for solana

61497fd

fix(ci): fail workflow when npm publish errors

0ba22a4

nikaaru requested a review from yeager-eren as a code owner May 31, 2025 15:20

nikaaru assigned yeager-eren May 31, 2025

nikaaru removed the request for review from yeager-eren May 31, 2025 15:21

nikaaru deployed to playground-preview May 31, 2025 15:34 — with GitHub Actions View deployment

nikaaru deployed to storybook-preview May 31, 2025 15:34 — with GitHub Actions View deployment

nikaaru deployed to app-preview May 31, 2025 15:34 — with GitHub Actions View deployment

yeager-eren force-pushed the next branch from d05c245 to 3f2dfb9 Compare June 11, 2025 11:23

yeager-eren requested review from mikasackermn, Ikari-Shinji-re, samobasquiat and RanGojo as code owners June 11, 2025 11:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(ci): fail workflow when npm publish errors #1159

fix(ci): fail workflow when npm publish errors #1159

Uh oh!

nikaaru commented May 31, 2025

Uh oh!

Uh oh!

fix(ci): fail workflow when npm publish errors #1159

Are you sure you want to change the base?

fix(ci): fail workflow when npm publish errors #1159

Uh oh!

Conversation

nikaaru commented May 31, 2025

Summary

How did you test this change?

Checklist:

Uh oh!

Uh oh!