Move Windows CNI startup into CNI function #9339
Open
+310
−313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9339 +/- ##
==========================================
- Coverage 19.52% 19.37% -0.16%
==========================================
Files 47 48 +1
Lines 4016 4042 +26
==========================================
- Hits 784 783 -1
- Misses 3189 3216 +27
Partials 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brandond
force-pushed
the
executor-cni
branch
5 times, most recently
from
9709cbb to
b431488
Compare
Removes several notable indirect deps by removing references to the k3s embedded executor: ``` github.com/bronze1man/goStrongswanVici github.com/cloudnativelabs/kube-router github.com/coreos/go-iptables github.com/flannel-io/flannel github.com/mdlayher/genetlink github.com/mdlayher/netlink github.com/mdlayher/socket golang.zx2c4.com/wireguard ``` Signed-off-by: Brad Davidson <[email protected]>
Moves CNI config and setup out of KubeProxy and Kubelet functions into dedicated CNI function Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
CNI is now part of the executor, we no longer have to disable the K3s embedded CNI by setting the backend to none. Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
executor-cni
branch
from
b431488 to
e8b1e05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Blocked on:
Types of Changes
bugfix, tech debt
Verification
See linked issue
Testing
Linked Issues
User-Facing Change
Further Comments