-
-
Notifications
You must be signed in to change notification settings - Fork 230
Enable fine-grained visibility controls for group members #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ericmeadows
wants to merge
11
commits into
rajnandan1:main
Choose a base branch
from
ericmeadows:feature/handle_visibility_for_group_members
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enable fine-grained visibility controls for group members #460
ericmeadows
wants to merge
11
commits into
rajnandan1:main
from
ericmeadows:feature/handle_visibility_for_group_members
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…manage its own visibility
…age and there are components that will be hidden
Author
|
@rajnandan1 - can you take a look? |
rajnandan1
reviewed
Aug 5, 2025
| */ | ||
| export function up(knex) { | ||
| return knex.schema.alterTable("monitors", function (table) { | ||
| table.boolean("enable_details_to_be_examined").notNullable().defaultTo(true); |
Owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let us tiny int for this, since there are nuances of how boolean is interpreted for pg/mysql/sqilite
Owner
|
can you add some screen shots |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #415
In order to add somewhat fine-grained display functionality, we have submitted the work we did internally to limit certain monitors from being publicly visible within groups. This allows teams to expand the items in a healthcheck without displaying those results publicly. This is somewhat similar, but more-enhanced, functionality from Kuma Uptime. In order to accomplish this, there needed to be a "two-way" switch that allows for one setting to override the other - members of a group can set their own visibility in a group setting, and the parent can turn off the visibility for all children.
Here's the rough user story/specification:
Here's the functionality checklist:
*when logged-in to let users know it's not visible publiclyPossible future functionality (feel free to request this if really needed):
*on the main page when the drill-down is going to be disabled publicly*means