Skip to content

Break down misago.threads #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 97 commits into
base: main
Choose a base branch
from
Open

Break down misago.threads #1992

wants to merge 97 commits into from

Conversation

rafalp
Copy link
Owner

@rafalp rafalp commented Sep 2, 2025 •
edited
Loading

Fixes #1991

Todo

  • Rename misago.privatethreadmembers to misago.privatethreads
  • Finish redirects tests
    • Remove unused fixtures from tests
    • Add tests that verify thread category's tree_id
    • Move generic views back to misago.threads
  • Move posting views from misago.threads to misago.posting (it already has cross-cutting logic for posting)
    • Generic StartView
    • Change naming order to ThreadAction[...]
    • Write tests
      • Test posting raises 404 if category doesnt exist
      • Test posting raises 404 if thread doesnt exist
      • Test post edit raises 404 if post doesnt belong to a thread
      • Add assert_contains(response, thread.title) to edit and reply views tests
    • Fix other apps tests
  • Move category selector to posting
  • Move thread updates views to misago.threadupdates
  • Move private thread views from misago.threads to misago.privatethreads
  • Rename & cleanup thread detail views and templates
  • Rename & cleanup threads lists views and templates
    • Break down lists views tests into threads and category thread list views

@rafalp rafalp added this to the Next feature release milestone Sep 2, 2025
@rafalp rafalp self-assigned this Sep 2, 2025
@rafalp rafalp added area: frontend This issue involves JavaScript, React.js and Node area: backend This issue involves Python, Django or dependency (eg. database) area: theme This issue involves HTML and CSS feature: threads list Lists of threads feature: thread page Thread and private thread pages labels Sep 2, 2025
@rafalp rafalp force-pushed the fix-1991-private-threads-app branch from 32fdd88 to 90ec76f Compare September 2, 2025 03:09
@coveralls
Copy link

coveralls commented Sep 2, 2025 •
edited
Loading

Coverage Status

coverage: 96.505% (-0.006%) from 96.511%
when pulling 180515f on fix-1991-private-threads-app
into 726da8c on main.

@rafalp rafalp mentioned this pull request Sep 3, 2025
Merged
3 tasks
@rafalp rafalp force-pushed the fix-1991-private-threads-app branch from 90ec76f to 894a60e Compare September 5, 2025 15:39
@rafalp rafalp force-pushed the fix-1991-private-threads-app branch from f5ac140 to 79e7f8a Compare September 5, 2025 17:36
@rafalp rafalp changed the title Private threads app Break down misago.threads Sep 7, 2025
rafalp added 15 commits October 2, 2025 23:39
@rafalp
Add permission for seeing hidden posts contents in private thread
6a9f2c9
@rafalp
Add extra test case to other category embedded attachment
c4e4c2f
@rafalp
Add tests for passing attachment from other category scenario
6414dff
@rafalp
Add other category post quote tests
8b9e0bd
@rafalp
Move private thread detail members tests to misago.privatethreads, de…
085cd8c 
…lete old tests from misago.threads
@rafalp
More work on thread detail view updates
d271106
@rafalp
Add tests for thread updates in thread detail view
736d754
@rafalp
Add tests for private thread detail view updates
7660808
@rafalp
Remove old thread_replies tests suite
7ea4d41
@rafalp
WIP more thread tests
5ed7043
@rafalp
Reply thread for thread detail view tests
17bca54
@rafalp
Add tests for locked private thread permission and reply to locked pr…
0a046ee 
…ivate thread permission
@rafalp
Rename ThreadsListView to ThreadListView
d13eaf0
@rafalp
CategoryThreadsList -> CategoryThreadList rename
513ab9f
@rafalp
WIP basic tests for thread list views
0854780
@rafalp
Copy link
Owner Author

rafalp commented Oct 10, 2025

This is only waiting for me to re-organize thread list views tests. After that I'll merge this and do a rollback of misago.posts app as a separate PR.

rafalp added 14 commits October 12, 2025 14:37
@rafalp
Refactor more thread list views tests
4792b2f
@rafalp
Break down thread list view polling tests
c55ba30
@rafalp
Break threads list mark as read tests into separate files
3faa70f
@rafalp
Update thread list view start thread visibility tests
4182c03
@rafalp
More work on thread list view tests
08dbd34
@rafalp
More thread list view tests
434111e
@rafalp
Fix private threads list moderator tests
1dc4afd
@rafalp
Add tests for different starter/last poster variants to thread list v…
b885f51 
…iews
@rafalp
Add tests for empty child category thread list
2cee7d9
@rafalp
Move more category thread list tests
50fe23a
@rafalp
Add child category thread inclusion on thread list tests
0871dfc
@rafalp
Move vanilla category tests to category thread list tests
96f18f3
@rafalp
Add tests for different user/viewer thread displaying on thread list …
a4f1cfd 
…views
@rafalp
Cleanup thread list views moderation actions
5c6e61a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rafalp rafalp

Labels

area: backend This issue involves Python, Django or dependency (eg. database) area: frontend This issue involves JavaScript, React.js and Node area: theme This issue involves HTML and CSS feature: thread page Thread and private thread pages feature: threads list Lists of threads

Projects

None yet

Milestone

Misago 0.40 alpha 1

Development

Successfully merging this pull request may close these issues.

Move private threads logic to misago.privatethreads app

2 participants

@rafalp @coveralls