Skip to content

adding borderCrossings as a param to avoid for matrix endpoint #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vivekjain1397
Copy link
Contributor

What?

Why?

How?

Screenshots (optional)

Anything Else? (optional)

@vivekjain1397 vivekjain1397 requested a review from gianiek August 1, 2024 18:41
Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 6:43pm

@corypisano
Copy link
Contributor

avoid borderCrossings only added to distance and directions API initially

@vivekjain1397 vivekjain1397 requested a review from kochis August 5, 2024 15:57
@@ -1069,7 +1069,7 @@ Calculates the travel distances and durations between multiple origins and desti
- **`destinations`** (string, required): A list of destinations. A pipe-delimited string in the format `latitude0,longitude0|latitude1,longitude1|...`.
- **`mode`** (string, required): The travel mode. A string, one of `car`, `truck`, `foot`, or `bike`.
- **`units`** (string, optional): The distance units. A string, `metric` or `imperial`. Defaults to `imperial` if not provided.
- **`avoid`** (string, optional): The features that calculated routes should avoid. A string, comma-separated, including one or more of `tolls`, `highways` and `ferries`. No features are avoided if not provided.
- **`avoid`** (string, optional): The features that calculated routes should avoid. A string, comma-separated, including one or more of `tolls`, `highways`, `ferries`, `borderCrossings`. No features are avoided if not provided.
Copy link
Collaborator

@tjulien tjulien Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corypisano thinking maybe borders would be simpler and more consistent with the other params 🤔 . If you agree I can make the docs and code change as well (but leave the old one in code as an alt for back compat) cc @vivekjain1397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants