Added separate code injection for fragment and vertex files. Defaults to original code injection if stageName is not found. #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to original code injection if stageName is not found.
|
Sorry, I'm a bit late, but now I have found the time to work a bit on the project and review this PR. Overall, it looks good to me, but I have some nitpicks.
|
racz16
reviewed
Aug 20, 2025
Comment on lines
+171
to
+176
| const injectionSource = | ||
| this.stage === ShaderStage.FRAGMENT | ||
| ? GlslEditor.CONFIGURATIONS.getFragInjectionSource() | ||
| : this.stage === ShaderStage.VERTEX | ||
| ? GlslEditor.CONFIGURATIONS.getVertInjectionSource() | ||
| : GlslEditor.CONFIGURATIONS.getCodeInjectionSource(); |
There was a problem hiding this comment.
It'd be nice to refactor this snippet into its own function, and with ifs instead of nested ternary operators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be useful when using separate frag and vert files. The current defaults for Fragment code injection and Vertex code injection are made for three.js.