Shrink queue process state in case of abnormal queue [member] process termination to reduce peak memory footprint #14523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
requested review from
michaelklishin,
the-mikedavis,
SimonUnge and
dumbbell
and removed request for
dcorbacho
lukebakken
force-pushed
the
lukebakken/fix-format-status
branch
from
ccdb859 to
459c0bc
Compare
lhoguin
reviewed
Sep 10, 2025
lukebakken
force-pushed
the
lukebakken/fix-format-status
branch
2 times, most recently
from
fe3e6d9 to
9f51488
Compare
lukebakken
force-pushed
the
lukebakken/fix-format-status
branch
from
9f51488 to
4a64e41
Compare
SimonUnge
reviewed
Sep 10, 2025
lukebakken
force-pushed
the
lukebakken/fix-format-status
branch
from
4a64e41 to
0263ae0
Compare
lukebakken
force-pushed
the
lukebakken/fix-format-status
branch
from
0263ae0 to
40772c2
Compare
lhoguin
reviewed
Sep 11, 2025
lhoguin
reviewed
Sep 11, 2025
lukebakken
force-pushed
the
lukebakken/fix-format-status
branch
from
40772c2 to
296c014
Compare
michaelklishin
changed the title
lukebakken
force-pushed
the
lukebakken/fix-format-status
branch
from
296c014 to
2cf753b
Compare
* Call `Mod:format_state/1` if exported to possibly truncate huge states * Add more information about truncated ram_pending_ack and disk_pending_ack * Add `log.error_logger_format_depth` cuttlefish schema value * Add `format_state/1` to `rabbit_channel` * Add `log.summarize_process_state`, default is `false`, to enable summarizing process state for crash logs. * Added `format_state` to `rabbit_classic_queue_index_v2` and `rabbit_classic_queue_store_v2` * Ensure `rabbit_channel:format_state/1` uses `summarize_process_state_when_logged`
lukebakken
force-pushed
the
lukebakken/fix-format-status
branch
from
2cf753b to
1022b9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mod:format_state/1if exported to possibly truncate huge stateslog.error_logger_format_depthcuttlefish schema valueYou can use this branch to test these changes - it calls
exit()the first time a delivery is attempted to a consumer:https://github.com/lukebakken/rmq-rabbitmq-server/tree/lukebakken/fix-format-status-test-exit
I've used it with PerfTest to crash the queue process:
Finally, see this discussion!
#14349