DO NOT MERGE Use Cowboy's new direct data delivery for HTTP/2 Websocket #14500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the latest Cowboy and Cowlib.
lhoguin
commented
Sep 8, 2025
| @@ -135,7 +135,7 @@ start_tls_listener(TLSConf0, CowboyOpts) -> | |||
| num_acceptors => get_env(num_ssl_acceptors, 10), | |||
| num_conns_sups => get_env(num_conns_sup, 1) | |||
| }, | |||
| case cowboy:start_tls(RanchRef, RanchTransportOpts, CowboyOpts) of | |||
| case cowboy:start_tls(RanchRef, RanchTransportOpts, CowboyOpts#{enable_connect_protocol => true}) of | |||
There was a problem hiding this comment.
This forces enable HTTP/2 Websocket. Not necessarily what we want. If enabled by default we want to be able to disable it.
lhoguin
commented
Sep 8, 2025
| %% We simulate PROXY headers when HTTP/2 is used to have src/dest. | ||
| upgrade(Req=#{version := 'HTTP/2', peer := Peer, sock := Sock, cert := Cert}, | ||
| Env, Handler, HandlerState, Opts) -> | ||
| logger:error("~p ~p ~p ~p ~p", [Req, Env, Handler, HandlerState, Opts]), |
There was a problem hiding this comment.
Obviously remove this before we are done.
lhoguin
commented
Sep 8, 2025
| @@ -56,9 +56,25 @@ | |||
| upgrade(Req, Env, Handler, HandlerState) -> | |||
| upgrade(Req, Env, Handler, HandlerState, #{}). | |||
|
|
|||
| %% We simulate PROXY headers when HTTP/2 is used to have src/dest. | |||
lhoguin
commented
Sep 8, 2025
| Env, Handler, HandlerState, Opts) -> | ||
| logger:error("~p ~p ~p ~p ~p", [Req, Env, Handler, HandlerState, Opts]), | ||
| {SrcAddr, SrcPort} = Peer, | ||
| {DestAddr, DestPort} = Sock, |
There was a problem hiding this comment.
Perhaps don't unwrap here, unwrap in rabbit_net functions.
lhoguin
commented
Sep 8, 2025
| dep_cowboy = hex 2.13.0 | ||
| dep_cowlib = hex 2.14.0 | ||
| dep_cowboy = git https://github.com/ninenines/cowboy direct-data_delivery-for-h2-websocket | ||
| dep_cowlib = git https://github.com/ninenines/cowlib master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the latest Cowboy and Cowlib.