-
Notifications
You must be signed in to change notification settings - Fork 4
feat: update docs for pop with latest changes #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Left a few nits. The main feedback I have for the changes is that I don't think we should invite users to modify specs directly.
|
@al3mart good to merge then? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Left a few minor comments but other than that great job on the docs!
| For Pop CLI versions <`0.3.0` the `pop build` command is `pop build parachain` | ||
| {% endhint %} | ||
| > [!TIP] | ||
| > For Pop CLI versions <`0.3.0` the `pop build` command is `pop build parachain` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this. Too old of a version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 129dcd0.
857ad99 to
129dcd0
Compare
* feat: update pop-install instructions from macos (#53) * feat: update docs for pop with latest changes (#55) * feat: update docs for pop call chain * feat: update docs about pop build spec * refactor: remove unused images * feat: update pop build spec docs * feat: add instruction on how to install from brew * refactor: address PR feedback * fix: review feedback * refactor: final v11 release (#56) * refactor: final v11 changes * refactor: remove tutorial * refactor: create new chain * refactor: chain terminology * refactor: remove gifs * Update pop-cli-for-appchains/guides/launch-a-chain/launch-a-known-chain.md Co-authored-by: Copilot <[email protected]> * Update pop-cli-for-appchains/guides/launch-a-chain/launch-a-known-chain.md Co-authored-by: Copilot <[email protected]> * Update README.md Co-authored-by: Copilot <[email protected]> * Update pop-cli-for-appchains/guides/launch-a-chain/launch-a-known-chain.md Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: José Molina Colmenero <[email protected]> Co-authored-by: Daan van der Plas <[email protected]> Co-authored-by: Copilot <[email protected]>
This PR:
pop call chaincommand.pop buildandpop build speccommands.