-
Notifications
You must be signed in to change notification settings - Fork 38
ci: publish on homebrew #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #666 +/- ##
=======================================
Coverage 77.36% 77.36%
=======================================
Files 109 109
Lines 25228 25228
Branches 25228 25228
=======================================
Hits 19518 19518
Misses 3728 3728
Partials 1982 1982 🚀 New features to boost your workflow:
|
tsenovilla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Intel Mac, working properly:
/usr/local/bin/pop
pop-cli 0.10.0
|
@al3mart waiting for your approval before merging. |
AlexD10S
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool!
Let's add this command in the docs: https://learn.onpop.io/welcome/install-pop-cli#id-2.-install-pop-cli
For what I read to be able to install it with brew install pop we need to create a pop Formula in https://github.com/Homebrew/homebrew-core, have you check that?
Here it goes! r0gue-io/pop-docs#53
I did, yes, but:
|
Closes #668.
This PR adds an extra step in the release workflow to update the version in pop-cli in the homebrew repository.
The new
HOMEBREW_TAP_TOKENsecret will have to be configured so that it has read and write permissions into that repository.You can currently try out the functionality this way: