Skip to content

Conversation

syroBx
Copy link
Collaborator

@syroBx syroBx commented Mar 26, 2025

Cover cohort builder high level test for #37

  • add_step
  • get_state
  • update_filter
  • restore state
  • plot_data
  • stats
  • remove_step

@syroBx syroBx requested review from galachad and krystian8207 March 26, 2025 18:10
@syroBx syroBx self-assigned this Mar 26, 2025
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.38%. Comparing base (086713f) to head (834a305).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #79      +/-   ##
==========================================
+ Coverage   66.41%   72.38%   +5.96%     
==========================================
  Files          11       11              
  Lines        1977     1977              
==========================================
+ Hits         1313     1431     +118     
+ Misses        664      546     -118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@galachad
Copy link
Member

Looks good, please move the sakila rda file into test/data/sakila directory. We will be using it only for tests.

Please add the license info about sakila in readme file in test/data/sakila.

@syroBx syroBx changed the title Add cohort builder 'add_step' function test Add cohort builder functions tests Apr 22, 2025
@syroBx syroBx changed the title Add cohort builder functions tests Add cohort builder high level functions tests Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants