-
Notifications
You must be signed in to change notification settings - Fork 333
Forward stdout/stderr from parallel tests #2163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I guess the question here is do we want to forward as we update the number of tests, or only at the end when we report the test failures etc. I can see arguments for either Fixes #2095
I am afraid that it will take a bit more than this. We need to read out the output as we go, (nearly) immediately as it happens, because otherwise the pipe between the processes will be full and the subprocess stops. This is possibly already happening in the CI jobs that are stuck. |
I was afraid that this solution was too simple. |
|
Yeah, that looks perfect to me. Thanks! |
Now that we read out stdout/stderr explicitly, we might read it out before the error is reported from a failed worker startup. Or if a task is a startup and not a test file (`path == NA`), then we put the stdout/stderr aside and use it in the error message.
@hadley This is done, I think, if you want to take another look. (I can't formally request a review from you, I guess because you are the original author?) |
(100% pure claude code)
I guess the question here is do we want to forward as we update the number of tests, or only at the end when we report the test failures etc. I can see arguments for either
Fixes #2095