Handle interrupts in tests #2148
Merged
+27
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't see any way to test this programmatically, so I've just been adding `Sys.sleep(10)` to a random test. Fixes #1464
hadley
commented
Jul 31, 2025
| stop_reporter = TRUE, | ||
| praise = TRUE, | ||
|
|
||
| initialize = function(stop_reporter = TRUE, praise = TRUE) { | ||
| super$initialize() | ||
| self$failures <- Stack$new() |
There was a problem hiding this comment.
This is a refactoring I included in this PR because it was confusing me — failures did not just track failing expectations, but all expectations that we need to inform the user about.
hadley
commented
Jul 31, 2025
| messages <- vapply(failures, issue_summary, rule = TRUE, character(1)) | ||
| if (length(messages) > 0) { | ||
| if (self$issues$size() == 0) { | ||
| if (self$praise && self$n_success > 0) { |
There was a problem hiding this comment.
The key change is to only report success if there was one actual success — normally if there are zero successes you'll get a skip, but that doesn't help with interrupts. (I also tried emitting a skip, but I think that adds additional unneeded noise).
lionel-
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see any way to test this programmatically, so I've been testing by adding
Sys.sleep(10)to a random test.Fixes #1464