Remove RNGScope usage for Rcpp exports #220
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #167.
This uses the
Rcpp::export(rng = false)
directive to opt out of Rcpp automatically addingRNGScope
to our exported functions.We do not make use of the R RNG, so this is safe to do, and is a 'free' boost to performance.
Crucially we still leave this RNGScope on the stack when evaluating all user callback code.
The original issue is solved:
Created on 2025-07-28 with reprex v2.1.1
I also ran a revdepcheck to be sure this doesn't affect downstream code.
@wch @jcheng5 fyi, pls shout if you see any problems with this.