-
Notifications
You must be signed in to change notification settings - Fork 293
Dynamic cert support, rewrite installers #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix optInt behavior with Microsoft Edge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still have about 10 more files to review (namely the cert installer classes and props loader), but most of what I've seen so far looks good. I'm going to just post what I have for now, until I can finish up the review later this week.
All comments addressed. @bberenz three comments still remain unresolved. |
All conversations have been resolved. This is ready for merge. |
Convert Windows certificate installer to JNA
Raw>Raster Print> HTML printing fails with AdoptOpenJDK 11 on Windows 10 First attempt resulted in an error complaining Java FX did not start, but I did not get the error after that.Error message coincided with logs finally giving up, but they logged "Waiting for JavaFX to start" for almost 90 seconds before letting the processor go; might be a problem if it happened on a machine with less RAM, but I was able to send other print jobs while it was waiting. Regular HTML prints are working fine, though. Do we check elsewhere for JavaFX when doing Raster Print on the Raw tab? |
Testing this branch with a LetsEncrypt certificate and it works, but the following error occurs:
|
Print-Server steps updated with 2.1.0-RC9+ commands. https://github.com/qzind/tray/wiki/Print-Server |
There seems to be an edge-case issue where Firefox may not be detected on MacOS during the installation process. The problem seems to stem from the Spotlight service not listing Firefox as installed. You can test this by calling the following command: system_profiler SPApplicationsDataType -xml |grep "Firefox" The fix is to stop and start the Spotlight service using the following command: sudo mdutil -a -i off
sudo mdutil -a -i on Then test for Firefox again: system_profiler SPApplicationsDataType -xml |grep "Firefox" Should output: <string>Firefox</string>
<string>Firefox 72.0.2</string>
<string>/Applications/Firefox.app</string> |
Moves all installation tasks to Java, allows certs to renew automatically. There's a bunch of enhancements in this PR, but I'll try to high-level them...
Download: https://github.com/tresf/tray/releases/tag/v2.10-RC8
features
certgen
Out with the old
widows-keygen.js
,linux-keygen.sh
andapple-keygen.sh
, in with the new, standardized scripts.... called as sudo or as a regular user. It'll install the cert in the user's certstore now, meaning ssl from IntelliJ is now possible.
uninstall
... called as sudo/admin of course
advanced
Internally we now use java for all install tasks...
... called as sudo/admin of course
launchers
Platform launchers have been improved to pass parameters directly to qz-tray.jar...