Skip to content

Conversation

kritchie
Copy link
Contributor

@kritchie kritchie commented Oct 6, 2018

This PR addresses GH-117 by refactoring the method name add_base_attribute to set_base_attribute

Prior to this change, the add_base_attribute had an idempotent definition :

self.base_attributes = kwargs

While the method declaration let's the user think that this method is indeed not idempotent by having the keyword add in the method declaration. Setting it to set_base_attribute will remove potential errors from users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant