-
Notifications
You must be signed in to change notification settings - Fork 51
Optimized onnx transform class via multithreading #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abhishek-singh591 <[email protected]>
Signed-off-by: abhishek-singh591 <[email protected]>
Signed-off-by: abhishek-singh591 <[email protected]>
Signed-off-by: abhishek-singh591 <[email protected]>
a505dc6
to
28b5279
Compare
@abhishek-singh591 this is good start, Can we verify a larger model. Say 70B? |
LLaMA 3.1 70B Performance ComparisonWithout Thread Pooling
With Thread Pooling
|
@vbaddi |
Signed-off-by: abhishek-singh591 <[email protected]>
Signed-off-by: abhishek-singh591 <[email protected]>
Signed-off-by: abhishek-singh591 <[email protected]>
Signed-off-by: abhishek-singh591 <[email protected]>
Signed-off-by: abhishek-singh591 <[email protected]>
3acff3c
to
ef9f188
Compare
Signed-off-by: abhishek-singh591 <[email protected]>
ef9f188
to
f8d9273
Compare
This was referenced Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ONNX Transform Optimization with Thread Pool
Refactored the ONNX transform class to use a thread pool for parallelizing tensor operations, replacing the previous iterative loop. This resulted in a notable performance boost in the FP16Clip transform and a marginal improvement in
split_tensor()
, which may have further optimization potential.Performance (LLaMA 3.1 8B)
Thread count is hardcoded to
os.cpu_count() * 4
to better handle I/O-intensive workloads. Performance may vary depending on the machine's threading capabilities, so results may not be exactly reproducible across environments.