default NPI file added #498
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-akuruvil
requested review from
quic-rishinr,
ochougul,
quic-hemagnih and
quic-amitraj
as code owners
quic-akuruvil
force-pushed
the
npi
branch
2 times, most recently
from
3073208 to
783670a
Compare
Signed-off-by: Ann Kuruvilla <[email protected]>
Signed-off-by: Ann Kuruvilla <[email protected]>
Signed-off-by: Ann Kuruvilla <[email protected]>
Signed-off-by: Ann Kuruvilla <[email protected]>
Signed-off-by: Ann Kuruvilla <[email protected]>
Signed-off-by: Ann Kuruvilla <[email protected]>
Signed-off-by: Ann Kuruvilla <[email protected]>
Signed-off-by: Ann Kuruvilla <[email protected]>
Signed-off-by: Ann Kuruvilla <[email protected]>
…and displaying non scaled loss value on console. (quic#527) Signed-off-by: Swati Allabadi <[email protected]> Co-authored-by: Swati Allabadi <[email protected]>
|
@quic-akuruvil since we have the fix for handling of CustomRMSNorm do we still need this PR? can you confirm? |
quic-akuruvil
commented
Aug 20, 2025
|
Thanks for confirming @quic-akuruvil. closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added default npi file for compilation of gemma3 in AIC.
If user provides a custom node precision file, it will override default one