Skip to content

Normale Validation-Attribute benutzen #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

MHajoha
Copy link
Member

@MHajoha MHajoha commented May 16, 2025

Da wir jetzt in einem Iframe sind, können wir in der Tat die "soft validation"-Logik rausschmeißen, ohne form submission zu blockieren. Das hat auch den Vorteil, dass das Popover nicht awkwardly versucht, innerhalb der Iframe-Grenzen zu bleiben, sondern vom Browser einfach darüber hinweg gerendert werden kann.

Ganz der Standard-Bootstrap-Logik habe ich es nicht überlassen, siehe JSDoc von validateInput.

Bonus: Die Attempt-Details-Seite zeigt jetzt auch die Responses der Steps an.

MHajoha added 2 commits May 14, 2025 12:26
Now that our question is in an iframe, we can use the normal validation attributes without preventing form submission.
@MHajoha MHajoha requested review from MartinGauk and janbritz May 16, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant