Skip to content

Conversation

Anthuang
Copy link

This fixes two bugs:

  1. If listShards returns multiple pages, then we run into an infinite loop with while (!nextToken.isEmpty), because nextToken will never be set back to null because:
if (returnedToken != null) {
  nextToken = returnedToken
  1. listShards cannot allow both StreamName and NextToken to be specified together.

@chadlagore
Copy link
Contributor

@itsvikramagr this is tested against streams with >1k shards which forces paging on the Kinesis API

@itsmesrds
Copy link

Does this read the equal number of messages too ? because I see there is a data skew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants