Skip to content

Conversation

@benfdking
Copy link
Collaborator

Summary

  • bound parser cache size and clear when threshold exceeded to prevent unbounded memory use

Testing

  • cargo test -p sqruff-lib-core

https://chatgpt.com/codex/tasks/task_e_68b6a6262c348330bc8c932c28d79bf2

@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Benchmark for 5e75f7e

Click to view benchmark
Test Base PR %
DepthMap::from_parent 61.0±0.53µs 60.3±2.14µs -1.15%
fix_complex_query 12.2±0.17ms 12.3±0.09ms +0.82%
fix_superlong 146.2±13.89ms 155.1±18.20ms +6.09%
parse_complex_query 4.2±0.11µs 4.1±0.05µs -2.38%
parse_expression_recursion 7.3±0.09µs 7.2±0.11µs -1.37%
parse_simple_query 1050.2±20.02ns 1055.7±13.37ns +0.52%

@github-actions
Copy link

github-actions bot commented Sep 3, 2025

Benchmark for 11a1324

Click to view benchmark
Test Base PR %
DepthMap::from_parent 59.6±0.82µs 60.9±0.88µs +2.18%
fix_complex_query 12.0±0.06ms 12.3±0.06ms +2.50%
fix_superlong 146.0±15.68ms 152.1±15.92ms +4.18%
parse_complex_query 4.2±0.05µs 4.1±0.05µs -2.38%
parse_expression_recursion 7.4±0.10µs 7.2±0.11µs -2.70%
parse_simple_query 1059.6±16.18ns 1068.9±15.24ns +0.88%

@benfdking benfdking force-pushed the codex/fix-memory-issue-with-sqruff-in-nvim branch from 300f70c to cb32b78 Compare September 3, 2025 17:11
@github-actions
Copy link

github-actions bot commented Sep 3, 2025

Benchmark for a830aa6

Click to view benchmark
Test Base PR %
DepthMap::from_parent 61.1±0.69µs 60.8±1.50µs -0.49%
fix_complex_query 12.1±0.12ms 12.3±0.46ms +1.65%
fix_superlong 140.8±16.92ms 148.9±16.15ms +5.75%
parse_complex_query 4.2±0.04µs 4.1±0.04µs -2.38%
parse_expression_recursion 7.2±0.09µs 7.3±0.07µs +1.39%
parse_simple_query 1077.6±15.14ns 1093.3±20.25ns +1.46%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant