Skip to content

Conversation

benfdking
Copy link
Collaborator

Reverts #1718

Copy link

Benchmark for fdb864a

Click to view benchmark
Test Base PR %
DepthMap::from_parent 61.0±0.71µs 60.0±1.33µs -1.64%
fix_complex_query 12.3±0.14ms 12.2±0.12ms -0.81%
fix_superlong 160.5±23.36ms 140.7±18.25ms -12.34%
parse_complex_query 4.1±0.06µs 4.1±0.04µs 0.00%
parse_expression_recursion 7.1±0.10µs 7.2±0.10µs +1.41%
parse_simple_query 1050.3±24.72ns 1069.2±15.29ns +1.80%

@benfdking benfdking force-pushed the revert-1718-revert-1698-claude/fix-tsql-parser-issues branch from 5fa7283 to f1934e0 Compare June 29, 2025 20:40
@benfdking benfdking force-pushed the revert-1718-revert-1698-claude/fix-tsql-parser-issues branch from f1934e0 to 06221b5 Compare June 29, 2025 20:40
Copy link

Benchmark for 51e2b03

Click to view benchmark
Test Base PR %
DepthMap::from_parent 61.4±0.65µs 61.1±1.49µs -0.49%
fix_complex_query 12.0±0.06ms 12.1±0.22ms +0.83%
fix_superlong 128.7±17.10ms 134.8±15.79ms +4.74%
parse_complex_query 4.2±0.05µs 4.2±0.06µs 0.00%
parse_expression_recursion 7.2±0.06µs 7.3±0.14µs +1.39%
parse_simple_query 1085.9±36.16ns 1080.2±12.38ns -0.52%

Copy link

openhands-ai bot commented Jun 29, 2025

Looks like there are a few issues preventing this PR from being merged!

  • GitHub Actions are failing:
    • PR Checks

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #1719

Feel free to include any additional details that might help me get this PR into a better state.

You can manage your notification settings

@fank
Copy link
Contributor

fank commented Jul 13, 2025

I think thzis is not needed anymore.

@benfdking
Copy link
Collaborator Author

Do you want to just close it?

@fank
Copy link
Contributor

fank commented Jul 14, 2025

Yes, as you said lets focus on dialect first.
I didn't notice that they are still so many unparseable sections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants