Skip to content

Conversation

VinzentRisch
Copy link
Contributor

closes #372

  • adds new collation actions for GenomeData[Genes] and GenomeData[Proteins]
  • refactors code for collation actions for loci and ortholog annotations with one helper function

@VinzentRisch
Copy link
Contributor Author

Hey @misialq
Do you agree with these changes? I created a helper function that handles all collations of loci, proteins, genes and ortholog annotations.
Before the collation of loci only handled artifacts that were not per sample. The new one can also handle per sample data.
I also removed the check for if the file already exists with the warning, because this is not done somewhere else. Or do you think this is something that would be beneficial?

@lizgehret lizgehret requested a review from misialq September 18, 2025 17:21
@lizgehret lizgehret moved this from Backlog to Needs Review in 2025.10 👻 Sep 18, 2025
@github-project-automation github-project-automation bot moved this to Backlog in 2025.10 👻 Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

ENH: add collation functions for GenomeData[Genes] and GenomeData[Proteins]
2 participants