Skip to content

Conversation

lizgehret
Copy link
Member

No description provided.

@gregcaporaso
Copy link
Member

gregcaporaso commented Aug 21, 2025

Note that the unit tests are passing for my updates to the aligner, but I'm still working on some real-world testing of these changes. I'll add some notes here as I go. As we discussed, we're still a little way off from merging these PRs across the distros - I should be done by the time that's all ready to go.

Update: I did some experimenting and documented the updates - all of that is here for now. I think the changes to _cutter.py are good to go, but I'm going to share with a few folks and will circle back if that changes.

Another update: I did some experimenting with the identity parameter today, and I do think we should drop it to 0.70 as I think with the new code we're not extracting some reads that do have reasonable alignments. I'm seeing some reads that are no longer extracted though that I can't currently explain (they forward and reverse alignments result in sequences that exceed my identity threshold), so we should add some additional unit tests of the new functionality here before these changes are merged to make sure that it's all working as expected. A possible reason for this is how the output of my new function interacts with the trimming/truncating/length parameters (e.g., am I dropping the primers from the extracted reads too soon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants