-
Notifications
You must be signed in to change notification settings - Fork 1
MAINT: adds plugin install tab for apple silicon arch #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying library with
|
Latest commit: |
c217f6e
|
Status: | ✅ Deploy successful! |
Preview URL: | https://d1a79922.library-b91.pages.dev |
Branch Preview URL: | https://apple-silicon-install-tab.library-b91.pages.dev |
u('tabItem', key({title: '[Fresh Install (Apple Silicon)]'}), [ | ||
u('code', key({lang: 'bash', class: '!my-3'}), create_silicon), | ||
]), | ||
u('tabItem', key({title: '[Fresh Install (all other architectures)]'}), [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The titles end up being pretty long, I wonder if we can just have an exception for (Apple Silicon)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, i know... i do worry about it being confusing if we only have one arch specified. let me think about other name options to see if there's still a way to convey this that's less verbose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

How do you feel about this @ebolyen?
Co-authored-by: Evan Bolyen <[email protected]>
@ebolyen, we addressed the comment that you had in our last meeting (i.e., the order of the tabs) and are going to merge this so the instructions are available. We couldn't remember if there were other front-end changes you wanted in this, but we figure we can get those in next - we just want the information up there first as the install instructions weren't working for Apple Silicon. |
closes #19