Skip to content

Conversation

lizgehret
Copy link
Member

closes #19

Copy link

cloudflare-workers-and-pages bot commented Jul 10, 2025

Deploying library with  Cloudflare Pages  Cloudflare Pages

Latest commit: c217f6e
Status: ✅  Deploy successful!
Preview URL: https://d1a79922.library-b91.pages.dev
Branch Preview URL: https://apple-silicon-install-tab.library-b91.pages.dev

View logs

u('tabItem', key({title: '[Fresh Install (Apple Silicon)]'}), [
u('code', key({lang: 'bash', class: '!my-3'}), create_silicon),
]),
u('tabItem', key({title: '[Fresh Install (all other architectures)]'}), [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The titles end up being pretty long, I wonder if we can just have an exception for (Apple Silicon)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i know... i do worry about it being confusing if we only have one arch specified. let me think about other name options to see if there's still a way to convey this that's less verbose

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2025-07-10 at 4 23 04 PM

How do you feel about this @ebolyen?

@lizgehret lizgehret requested a review from ebolyen July 10, 2025 23:24
@github-project-automation github-project-automation bot moved this to Backlog in 2025.10 👻 Jul 10, 2025
@lizgehret lizgehret moved this from Backlog to Needs Review in 2025.10 👻 Jul 10, 2025
@gregcaporaso gregcaporaso removed the request for review from ebolyen September 4, 2025 18:27
@gregcaporaso
Copy link
Member

@ebolyen, we addressed the comment that you had in our last meeting (i.e., the order of the tabs) and are going to merge this so the instructions are available. We couldn't remember if there were other front-end changes you wanted in this, but we figure we can get those in next - we just want the information up there first as the install instructions weren't working for Apple Silicon.

@gregcaporaso gregcaporaso merged commit 1980391 into main Sep 4, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Needs Review to Changelog Needed in 2025.10 👻 Sep 4, 2025
@lizgehret lizgehret moved this from Changelog Needed to Completed in 2025.10 👻 Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

MAINT: add tab for apple silicon install instructions
3 participants