NTT Implementation for PolynomialRingZq #462
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ations within the math crate
…ke benchmarks easier to read
…cation, addition and subtraction operations
Marvin-Beckmann
added
enhancement📈
Marvin-Beckmann
requested review from
LPorzenheim
and removed request for
jnsiemer
LPorzenheim
reviewed
Jul 7, 2025
| /// This function allows to initialize a [`NTTBasisPolynomialRingZq`] | ||
| /// object. | ||
| /// We currently only allow for two kinds of moduli to accompany the construction: | ||
| /// It must be either cyclotomic (`X^n - 1`) or negacyclic (`X^n + 1`) convoluted wrapping (also submitted in the algorithm) |
LPorzenheim
reviewed
Jul 7, 2025
| /// Parameters: | ||
| /// - `n`: the degree of the polynomial | ||
| /// - `root_of_unity`: the `n`-th or `2n`-th root of unity | ||
| /// - `q`: the modulus of the cyclotomic polynomial |
There was a problem hiding this comment.
Misleading to call it cyclotomic because it only applies to one case?
LPorzenheim
reviewed
Jul 7, 2025
| /// This function essentially computes the included butterliy computations for each provided | ||
| /// chunk. | ||
| /// The chunk is double the size of the stride. | ||
| /// The computation currently performs the standard butterly operation from Gentleman-Sande. |
There was a problem hiding this comment.
butterfly, see first sentence as well
LPorzenheim
reviewed
Jul 14, 2025
| } | ||
| res | ||
| } | ||
|
|
There was a problem hiding this comment.
Tests missing for intt working correctly as well as different modulus (as in ntt)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the NTT for
Even though I included several optimisations I found, I did not manage to make the implication faster than direct multiplication using FLINT, where the multiplication is already very fast.
I included benchmarks and added an additional disclaimer in the comment of the NTT-multiplication that is is not slower.
I tested it for common parameter-sets that I have found.
I found that the overhead necessary for multithreading also exceeds the runtime of the multiplication, so this was not an option to reduce the runtime, but for future potential optimisations I kept the framework to enable multi-threading within the code-base.
Testing
Checklist: