fix: use standard HTTP/HTTPS ports when not specified in URL Previous… #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly, when a URL was provided without an explicit port, the client would fall back to the constructor's port parameter (default 6334), causing URLs like https://example.com to incorrectly use port 6334 instead of the standard HTTPS port 443. Now properly defaults to: - Port 443 for HTTPS URLs - Port 80 for HTTP URLs - Constructor port parameter for other protocols Fixes incorrect port resolution for standard HTTP/HTTPS URLs.
2 tasks
|
When will this fix get released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a URL was provided without an explicit port, the client would fall back to the constructor's port parameter (default 6334), causing URLs like https://example.com to incorrectly use port 6334 instead of the standard HTTPS port 443. Now properly defaults to: - Port 443 for HTTPS URLs - Port 80 for HTTP URLs - Constructor port parameter for other protocols Fixes incorrect port resolution for standard HTTP/HTTPS URLs.
related issue: #94