Skip to content

Conversation

@ameraner
Copy link
Member

@ameraner ameraner commented Nov 14, 2025

This PR moves two readers that were pending deprecation since 4 years (FCI #1713) and 2 years (VIIRS, 65511ec, #2531) to full deprecation.

Now, instead of a warning, a ValueError will be raised, still pointing to the new reader name.

@ameraner ameraner added this to the v1.0 milestone Nov 14, 2025
@ameraner ameraner self-assigned this Nov 14, 2025
@ameraner ameraner added component:readers backwards-incompatibility Causes backwards incompatibility or introduces a deprecation labels Nov 14, 2025
@ameraner ameraner linked an issue Nov 14, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.29%. Comparing base (4f0befb) to head (8b5be7a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3298      +/-   ##
==========================================
- Coverage   96.30%   96.29%   -0.02%     
==========================================
  Files         463      463              
  Lines       58863    58863              
==========================================
- Hits        56689    56683       -6     
- Misses       2174     2180       +6     
Flag Coverage Δ
behaviourtests 3.61% <100.00%> (ø)
unittests 96.38% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 19360172961

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on update_deprecated_readers at 96.372%

Totals Coverage Status
Change from base Build 19293346095: 96.4%
Covered Lines: 56561
Relevant Lines: 58690

💛 - Coveralls

@ameraner ameraner moved this to In Progress in Remote PCW Autumn 2025 Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backwards-incompatibility Causes backwards incompatibility or introduces a deprecation component:readers

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Move fci_l1c_fdhsi reader from pending to full deprecation

2 participants