Skip to content

Conversation

@pnuu
Copy link
Member

@pnuu pnuu commented Oct 17, 2025

This PR does some refactoring to pyspectral.near_infrared_reflectance module.

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest pyspectral
  • Passes flake8 pyspectral
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@pnuu pnuu self-assigned this Oct 17, 2025
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 83.90805% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.34%. Comparing base (d4ea15a) to head (06eefad).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pyspectral/near_infrared_reflectance.py 83.90% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   90.28%   90.34%   +0.05%     
==========================================
  Files          22       22              
  Lines        2523     2538      +15     
==========================================
+ Hits         2278     2293      +15     
  Misses        245      245              
Flag Coverage Δ
unittests 90.34% <83.90%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pnuu pnuu requested review from adybbroe and mraspaud October 17, 2025 10:46
@adybbroe
Copy link
Collaborator

Thanks @pnuu nice work. Haven't carefully checked everything yet, it is some re-arrangements, so just wonder if you are confident with the test coverage of all this?

Also, perhaps you saw there was some discussion recently about the "nir" and "near infrared" here, as it is a bit mis-leading and strictly not true, as we are operating with what is normally termed the mid-wave IR range. SO, should this be part of this re-factoring, or rather another one?

I guess that changing the name of functions will break compatibility in Satpy for instance, so should probably go in another PR...

@pnuu
Copy link
Member Author

pnuu commented Oct 22, 2025

The coverage report says 14 lines miss coverage. Haven't looked too closely, but likely something I don't have much experience with.

The naming change with associated aliases and deprecation warnings is certainly a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants