Consider even block sizes in drop block 2d #9157
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version,
drop_block2d
only seems to work with block sizes that are odd-sized i.e. 3, 5, 7, 9, ... However, this is not covered in the documentation so it took me a bit to figure out. Fixing it requires applying asymmetric padding, whichmax_pool2d
doesn't support, so an explicit padding viaF.pad
is necessary in this case. Also, I reckon that it might be much simpler to comment this aspect in the documentation and include a check in the code than accepting even block sizes.This fix only applies to the 2d version and does not fix
drop_block3d
.