-
Notifications
You must be signed in to change notification settings - Fork 627
Update PPO tests to Llama3 #2808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SalmanMohammadi
wants to merge
12
commits into
pytorch:main
Choose a base branch
from
SalmanMohammadi:update_ppo_tests_llama3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update PPO tests to Llama3 #2808
SalmanMohammadi
wants to merge
12
commits into
pytorch:main
from
SalmanMohammadi:update_ppo_tests_llama3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2808
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d7dd94b with merge base 337cd7c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
joecummings
reviewed
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2806
Why did I remove the loss values for the other GPU runners?
Because we don't use them in our CI. I'll add them back if this changes. I think this does mean that this test won't run on some local GPUs, but I'm not sure who out there is running full recipe tests locally. I want to meet this person if they exist and shake their hand.