Fix bugs in initial_load_in_hf when enable_weight_tying=true in Qwen3 #1999
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add checks for weight tying in state_dict processing
Co-authored-by: Shuhua Yu <[email protected]>
Co-authored-by: Shuhua Yu <[email protected]>
shuhuayu
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
meta-cla
bot
added
the
CLA Signed
Contributor
Author
|
Added a test training from qwen3 4b huggingface checkpoint, which omits 
|
tianyu-l
reviewed
Nov 7, 2025
| self.model_args.enable_weight_tying | ||
| and "lm_head.weight" not in hf_state_dict | ||
| ): | ||
| if "model.embed_tokens.weight" in hf_state_dict: |
Contributor
There was a problem hiding this comment.
why this if? shouldn't we assert the existence of embedding?
My guess is that this if was copied from somewhere PP can be enabled, so embedding is on some ranks but not others. But with PP, we'd also require embedding and lm_head to be on the same rank -- o/w how would you be able to load the lm_head weights?
Contributor
Author
There was a problem hiding this comment.
Thx for this point, added an assertion here.
jquesnelle
pushed a commit
to NousResearch/torchtitan
that referenced
this pull request
Nov 10, 2025
…pytorch#1999) Rebased on main to merge this pr: pytorch#1964 --------- Co-authored-by: William <[email protected]> Co-authored-by: Achazwl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on main to merge this pr: #1964