Skip to content

Add logging for partitioner methods #3290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add logging for partitioner methods #3290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions torchrec/distributed/planner/partitioners.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,9 @@ def partition(
# The topology updates are done after the end of all the placements (the other
# in the example is just for clarity).
"""
logger.info(
f"GreedyPerfPartitioner - sort_by: {self._sort_by}, balance_modules: {self._balance_modules}"
)

_topology: Topology = copy.deepcopy(storage_constraint)
minheap_devices: Optional[List[OrderedDeviceHardware]] = None
Expand Down Expand Up @@ -587,6 +590,10 @@ def partition(
within the tolerance of the original plan that uses the least amount
of memory.
"""
logger.info(
f"MemoryBalancedPartitioner - _max_search_count: {self._max_search_count}, _tolerance: {self._tolerance}, _balance_modules: {self._balance_modules}"
)

_perf_model: PerfModel = NoopPerfModel(storage_constraint)
_partitioner = GreedyPerfPartitioner(
sort_by=SortBy.PERF, balance_modules=self._balance_modules
Expand Down
Loading