Add LinearProgrammingPlanner option to benchmark_train_sparsenn #3070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76231527 |
…ugh GPUs Summary: 1) Add comprehensive docstrings to RunOptions, EmbeddingTablesConfig, and PipelineConfig. 2) Replace direct return with hypothesis.assume(torch.cuda.is_available() and torch.cuda.device_count() >= world_size) Differential Revision: D76160331
Summary: Created an EmbeddingShardingPlanner in the runner function after generating the unsharded model and modified _generate_sharded_model_and_optimizer to accept and use this planner. This change enables optimized sharding of embedding tables based on the topology. Differential Revision: D76188112
SSYernar
added a commit
to SSYernar/torchrec
that referenced
this pull request
Jun 9, 2025
…rch#3070) Summary: This change adds the ability to select different sharding planners when running sparse neural network benchmarks. Previously, the benchmark code only used EmbeddingShardingPlanner, but now users can choose between EmbeddingShardingPlanner and LinearProgrammingPlanner. The changes include: 1. Adding a new `planner_type` parameter to the `RunOptions` class 2. Creating a new `_generate_planner` function that returns the appropriate planner based on the selected type 3. Updating the runner function to use this new function 4. Updating type annotations to support both planner types Differential Revision: D76231527
SSYernar
force-pushed
the
export-D76231527
branch
from
0981c9d to
cfbb45e
Compare
…rch#3070) Summary: Pull Request resolved: pytorch#3070 This change adds the ability to select different sharding planners when running sparse neural network benchmarks. Previously, the benchmark code only used EmbeddingShardingPlanner, but now users can choose between EmbeddingShardingPlanner and LinearProgrammingPlanner. The changes include: 1. Adding a new `planner_type` parameter to the `RunOptions` class 2. Creating a new `_generate_planner` function that returns the appropriate planner based on the selected type 3. Updating the runner function to use this new function 4. Updating type annotations to support both planner types Differential Revision: D76231527
|
This pull request was exported from Phabricator. Differential Revision: D76231527 |
SSYernar
force-pushed
the
export-D76231527
branch
from
cfbb45e to
82887c3
Compare
SSYernar
added a commit
to SSYernar/torchrec
that referenced
this pull request
Jun 10, 2025
…rch#3070) Summary: This change adds the ability to select different sharding planners when running sparse neural network benchmarks. Previously, the benchmark code only used EmbeddingShardingPlanner, but now users can choose between EmbeddingShardingPlanner and LinearProgrammingPlanner. The changes include: 1. Adding a new `planner_type` parameter to the `RunOptions` class 2. Creating a new `_generate_planner` function that returns the appropriate planner based on the selected type 3. Updating the runner function to use this new function 4. Updating type annotations to support both planner types Differential Revision: D76231527
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds the ability to select different sharding planners when running sparse neural network benchmarks. Previously, the benchmark code only used EmbeddingShardingPlanner, but now users can choose between EmbeddingShardingPlanner and LinearProgrammingPlanner.
The changes include:
planner_typeparameter to theRunOptionsclass_generate_plannerfunction that returns the appropriate planner based on the selected typeDifferential Revision: D76231527