Mapping between runtime and aot intermediate outputs #11624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11624
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit efcd4d1 with merge base a6e104c ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76442807 |
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
|
This pull request was exported from Phabricator. Differential Revision: D76442807 |
Juntian777
added a commit
to Juntian777/executorch
that referenced
this pull request
Jun 12, 2025
Summary: Pull Request resolved: pytorch#11624 This PR introduces a function map_runtime_aot_intermediate_outputs that maps runtime intermediate outputs to AOT intermediate outputs by identifying overlapping(between aot and runtime) debug handles and combining them into a single key that could handle below various mapping scenarios. 1. No Overlaps: There are no overlapping debug handles between AOT and runtime outputs. 2. 1-to-1 Mapping: A straightforward mapping where one AOT debug handle corresponds directly to one runtime debug handle. 3. 1-to-N Mapping: A single AOT debug handle maps to multiple runtime debug handles. 4. N-to-1 Mapping: Multiple AOT debug handles map to a single runtime debug handle. 5. N-to-N Mapping: More intricate scenarios where multiple AOT and runtime debug handles form a chain of overlaps In all cases where multiple debug handles are involved (N-to-1, 1-to-N, or N-to-N), the function merges these into a single combined debug handle and retains only the last intermediate output for each mapping. In order to handle all cases, the code first does some pre-processing to the input, then constructs a graph of nodes representing debug handles and outputs, identifies connected components using DFS, and creates mappings for overlapping components, merging debug handles and retaining the last output. This function will be used later in the Inspector Numerical Comparator class to create the mapping. Differential Revision: D76442807
Juntian777
force-pushed
the
export-D76442807
branch
from
da6beae to
39c94db
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76442807 |
Juntian777
force-pushed
the
export-D76442807
branch
from
39c94db to
422d801
Compare
Juntian777
added a commit
to Juntian777/executorch
that referenced
this pull request
Jun 12, 2025
Summary: Pull Request resolved: pytorch#11624 This PR introduces a function map_runtime_aot_intermediate_outputs that maps runtime intermediate outputs to AOT intermediate outputs by identifying overlapping(between aot and runtime) debug handles and combining them into a single key that could handle below various mapping scenarios. 1. No Overlaps: There are no overlapping debug handles between AOT and runtime outputs. 2. 1-to-1 Mapping: A straightforward mapping where one AOT debug handle corresponds directly to one runtime debug handle. 3. 1-to-N Mapping: A single AOT debug handle maps to multiple runtime debug handles. 4. N-to-1 Mapping: Multiple AOT debug handles map to a single runtime debug handle. 5. N-to-N Mapping: More intricate scenarios where multiple AOT and runtime debug handles form a chain of overlaps In all cases where multiple debug handles are involved (N-to-1, 1-to-N, or N-to-N), the function merges these into a single combined debug handle and retains only the last intermediate output for each mapping. In order to handle all cases, the code first does some pre-processing to the input, then constructs a graph of nodes representing debug handles and outputs, identifies connected components using DFS, and creates mappings for overlapping components, merging debug handles and retaining the last output. This function will be used later in the Inspector Numerical Comparator class to create the mapping. Differential Revision: D76442807
|
This pull request was exported from Phabricator. Differential Revision: D76442807 |
Juntian777
added a commit
to Juntian777/executorch
that referenced
this pull request
Jun 12, 2025
Summary: Pull Request resolved: pytorch#11624 This PR introduces a function map_runtime_aot_intermediate_outputs that maps runtime intermediate outputs to AOT intermediate outputs by identifying overlapping(between aot and runtime) debug handles and combining them into a single key that could handle below various mapping scenarios. 1. No Overlaps: There are no overlapping debug handles between AOT and runtime outputs. 2. 1-to-1 Mapping: A straightforward mapping where one AOT debug handle corresponds directly to one runtime debug handle. 3. 1-to-N Mapping: A single AOT debug handle maps to multiple runtime debug handles. 4. N-to-1 Mapping: Multiple AOT debug handles map to a single runtime debug handle. 5. N-to-N Mapping: More intricate scenarios where multiple AOT and runtime debug handles form a chain of overlaps In all cases where multiple debug handles are involved (N-to-1, 1-to-N, or N-to-N), the function merges these into a single combined debug handle and retains only the last intermediate output for each mapping. In order to handle all cases, the code first does some pre-processing to the input, then constructs a graph of nodes representing debug handles and outputs, identifies connected components using DFS, and creates mappings for overlapping components, merging debug handles and retaining the last output. This function will be used later in the Inspector Numerical Comparator class to create the mapping. Reviewed By: Gasoonjia Differential Revision: D76442807
Juntian777
force-pushed
the
export-D76442807
branch
from
422d801 to
d4a34aa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76442807 |
Juntian777
force-pushed
the
export-D76442807
branch
from
d4a34aa to
6634735
Compare
Juntian777
added a commit
to Juntian777/executorch
that referenced
this pull request
Jun 12, 2025
Summary: Pull Request resolved: pytorch#11624 This PR introduces a function map_runtime_aot_intermediate_outputs that maps runtime intermediate outputs to AOT intermediate outputs by identifying overlapping(between aot and runtime) debug handles and combining them into a single key that could handle below various mapping scenarios. 1. No Overlaps: There are no overlapping debug handles between AOT and runtime outputs. 2. 1-to-1 Mapping: A straightforward mapping where one AOT debug handle corresponds directly to one runtime debug handle. 3. 1-to-N Mapping: A single AOT debug handle maps to multiple runtime debug handles. 4. N-to-1 Mapping: Multiple AOT debug handles map to a single runtime debug handle. 5. N-to-N Mapping: More intricate scenarios where multiple AOT and runtime debug handles form a chain of overlaps In all cases where multiple debug handles are involved (N-to-1, 1-to-N, or N-to-N), the function merges these into a single combined debug handle and retains only the last intermediate output for each mapping. In order to handle all cases, the code first does some pre-processing to the input, then constructs a graph of nodes representing debug handles and outputs, identifies connected components using DFS, and creates mappings for overlapping components, merging debug handles and retaining the last output. This function will be used later in the Inspector Numerical Comparator class to create the mapping. Reviewed By: Gasoonjia Differential Revision: D76442807
|
This pull request was exported from Phabricator. Differential Revision: D76442807 |
Juntian777
force-pushed
the
export-D76442807
branch
from
6634735 to
e144487
Compare
Juntian777
added a commit
to Juntian777/executorch
that referenced
this pull request
Jun 13, 2025
Summary: Pull Request resolved: pytorch#11624 This PR introduces a function map_runtime_aot_intermediate_outputs that maps runtime intermediate outputs to AOT intermediate outputs by identifying overlapping(between aot and runtime) debug handles and combining them into a single key that could handle below various mapping scenarios. 1. No Overlaps: There are no overlapping debug handles between AOT and runtime outputs. 2. 1-to-1 Mapping: A straightforward mapping where one AOT debug handle corresponds directly to one runtime debug handle. 3. 1-to-N Mapping: A single AOT debug handle maps to multiple runtime debug handles. 4. N-to-1 Mapping: Multiple AOT debug handles map to a single runtime debug handle. 5. N-to-N Mapping: More intricate scenarios where multiple AOT and runtime debug handles form a chain of overlaps In all cases where multiple debug handles are involved (N-to-1, 1-to-N, or N-to-N), the function merges these into a single combined debug handle and retains only the last intermediate output for each mapping. In order to handle all cases, the code first does some pre-processing to the input, then constructs a graph of nodes representing debug handles and outputs, identifies connected components using DFS, and creates mappings for overlapping components, merging debug handles and retaining the last output. This function will be used later in the Inspector Numerical Comparator class to create the mapping. Reviewed By: Gasoonjia Differential Revision: D76442807
|
This pull request was exported from Phabricator. Differential Revision: D76442807 |
Juntian777
added a commit
to Juntian777/executorch
that referenced
this pull request
Jun 13, 2025
Summary: Pull Request resolved: pytorch#11624 This PR introduces a function map_runtime_aot_intermediate_outputs that maps runtime intermediate outputs to AOT intermediate outputs by identifying overlapping(between aot and runtime) debug handles and combining them into a single key that could handle below various mapping scenarios. 1. No Overlaps: There are no overlapping debug handles between AOT and runtime outputs. 2. 1-to-1 Mapping: A straightforward mapping where one AOT debug handle corresponds directly to one runtime debug handle. 3. 1-to-N Mapping: A single AOT debug handle maps to multiple runtime debug handles. 4. N-to-1 Mapping: Multiple AOT debug handles map to a single runtime debug handle. 5. N-to-N Mapping: More intricate scenarios where multiple AOT and runtime debug handles form a chain of overlaps In all cases where multiple debug handles are involved (N-to-1, 1-to-N, or N-to-N), the function merges these into a single combined debug handle and retains only the last intermediate output for each mapping. In order to handle all cases, the code first does some pre-processing to the input, then constructs a graph of nodes representing debug handles and outputs, identifies connected components using DFS, and creates mappings for overlapping components, merging debug handles and retaining the last output. This function will be used later in the Inspector Numerical Comparator class to create the mapping. Reviewed By: Gasoonjia Differential Revision: D76442807
Juntian777
force-pushed
the
export-D76442807
branch
from
e144487 to
7a0ad61
Compare
Summary: Pull Request resolved: pytorch#11624 This PR introduces a function map_runtime_aot_intermediate_outputs that maps runtime intermediate outputs to AOT intermediate outputs by identifying overlapping(between aot and runtime) debug handles and combining them into a single key that could handle below various mapping scenarios. 1. No Overlaps: There are no overlapping debug handles between AOT and runtime outputs. 2. 1-to-1 Mapping: A straightforward mapping where one AOT debug handle corresponds directly to one runtime debug handle. 3. 1-to-N Mapping: A single AOT debug handle maps to multiple runtime debug handles. 4. N-to-1 Mapping: Multiple AOT debug handles map to a single runtime debug handle. 5. N-to-N Mapping: More intricate scenarios where multiple AOT and runtime debug handles form a chain of overlaps In all cases where multiple debug handles are involved (N-to-1, 1-to-N, or N-to-N), the function merges these into a single combined debug handle and retains only the last intermediate output for each mapping. In order to handle all cases, the code first does some pre-processing to the input, then constructs a graph of nodes representing debug handles and outputs, identifies connected components using DFS, and creates mappings for overlapping components, merging debug handles and retaining the last output. This function will be used later in the Inspector Numerical Comparator class to create the mapping. Reviewed By: Gasoonjia Differential Revision: D76442807
|
This pull request was exported from Phabricator. Differential Revision: D76442807 |
Juntian777
force-pushed
the
export-D76442807
branch
from
7a0ad61 to
efcd4d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR introduces a function map_runtime_aot_intermediate_outputs that maps runtime intermediate outputs to AOT intermediate outputs by identifying overlapping(between aot and runtime) debug handles and combining them into a single key that could handle below various mapping scenarios.
In all cases where multiple debug handles are involved (N-to-1, 1-to-N, or N-to-N), the function merges these into a single combined debug handle and retains only the last intermediate output for each mapping.
In order to handle all cases, the code first does some pre-processing to the input, then constructs a graph of nodes representing debug handles and outputs, identifies connected components using DFS, and creates mappings for overlapping components, merging debug handles and retaining the last output.
This function will be used later in the Inspector Numerical Comparator class to create the mapping.
Differential Revision: D76442807