[do not land] Support for Header File Generation in DTYPE Selective Build in OSS #11617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11617
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 70a92b3 with merge base df4c12e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
BujSet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of the process for enabling the dtype selective build flow requires a header file to be generated that includes information about kernel operators and their dtypes. This change adds support for generating this header file when operators are specified. This functionality is enabled via the command line flag:
-DEXECUTORCH_DTYPE_GEN_HEADER=ON. When enabled, the resultantselected_op_variants.hfile will be generated.Test plan
Updated
examples/selective_build/test_selective_build.shto include an example function that shows how to enable dtype header generation. Runningbash ./examples/selective_build/test_selective_build.sh cmakeproduces a header file atcmake-out/examples/selective_build/select_build_lib/selected_op_variants.hwhich contains selective build information. Note, the example intest_selective_build.shcurrently does not have dtype information, however the functionality of this feature was verified on other tests (e.g. mv3). These tests will be included in a future PR after #11601 successfully merges.